Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17233 )
Change subject: KUDU-2612: allow terminal txn ops to succeed if txn hasn't started ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17233/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17233/2//COMMIT_MSG@9 PS2, Line 9: This patch allows ABORT_TXN and FINALIZE_COMMIT ops to proceed even if : the participant hasn't yet initialized the transaction Could you add more colors on why it's desirable to allow an 'empty' participant to successfully finalize committing a transaction? Or that's not the case at all? http://gerrit.cloudera.org:8080/#/c/17233/2//COMMIT_MSG@13 PS2, Line 13: TxnOpDispatchers How does this work in case of non-empty TxnOpDispatcher when receiving FINALIZE_COMMIT (if that possible at all)? What does a client see in that case if it's in process of submitting a write operation? http://gerrit.cloudera.org:8080/#/c/17233/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/17233/2/src/kudu/tablet/tablet.cc@1226 PS2, Line 1226: auto txn_rowsets = nit: it seems result isn't needed? -- To view, visit http://gerrit.cloudera.org:8080/17233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c864b4f14e42008d3aa8f4454c8b2abf9bb766 Gerrit-Change-Number: 17233 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Mar 2021 03:35:52 +0000 Gerrit-HasComments: Yes
