Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17233 )
Change subject: KUDU-2612: allow ABORT_TXN txn ops to succeed if txn hasn't started ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Looks good overall, but I'm confused with CheckExistingMetadata() now. confu http://gerrit.cloudera.org:8080/#/c/17233/4/src/kudu/tablet/txn_participant.h File src/kudu/tablet/txn_participant.h: http://gerrit.cloudera.org:8080/#/c/17233/4/src/kudu/tablet/txn_participant.h@268 PS4, Line 268: Returns an error if the tablet has metadata for this transaction Now whis became confusing: what if 'state_' == kCommitted and expected_metadata_state == kCommitted as well? As of now, this method/function returns Status::OK(). http://gerrit.cloudera.org:8080/#/c/17233/4/src/kudu/tablet/txn_participant.h@290 PS4, Line 290: if (PREDICT_FALSE(state_ == kInitializing)) { readability nit: would it be easier to reason about possible outcomes if it were written as if (state_ != kInitializing) { return Status::OK(); } ... ? -- To view, visit http://gerrit.cloudera.org:8080/17233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c864b4f14e42008d3aa8f4454c8b2abf9bb766 Gerrit-Change-Number: 17233 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 02 Apr 2021 23:56:13 +0000 Gerrit-HasComments: Yes
