Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17176 )
Change subject: [master] Check for 'last_known_addr' field when adding master ...................................................................... Patch Set 2: Code-Review+1 (2 comments) overall lgtm, just a few nits about the readability of the comment for the new block of code in master.cc http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc@515 PS2, Line 515: // If a new master is being added to a single master configuration check that nit: add a comma after 'configuration' to increase comment's readibility. http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc@516 PS2, Line 516: // the current leader master has the 'last_known_addr' populated otherwise nit: add a period after 'populated' and subsequently capitalize 'otherwise'. -- To view, visit http://gerrit.cloudera.org:8080/17176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb Gerrit-Change-Number: 17176 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 29 Mar 2021 19:06:39 +0000 Gerrit-HasComments: Yes
