Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17176 )
Change subject: [master] Check for 'last_known_addr' field when adding master ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc@515 PS2, Line 515: // If a new master is being added to a single master configuration, check that > nit: add a comma after 'configuration' to increase comment's readibility. Done http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc@516 PS2, Line 516: // the current leader master has the 'last_known_addr' populated. Otherwise > nit: add a period after 'populated' and subsequently capitalize 'otherwise' Done -- To view, visit http://gerrit.cloudera.org:8080/17176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb Gerrit-Change-Number: 17176 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 31 Mar 2021 18:01:32 +0000 Gerrit-HasComments: Yes
