Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17217/1/src/kudu/integration-tests/txn_write_ops-itest.cc File src/kudu/integration-tests/txn_write_ops-itest.cc: http://gerrit.cloudera.org:8080/#/c/17217/1/src/kudu/integration-tests/txn_write_ops-itest.cc@662 PS1, Line 662: TEST_F(TxnWriteOpsITest, TxnWriteAfterCommit) { > Thank you for fixing the underlying issues and enabling this scenario! Definitely. Thanks for authoring it! http://gerrit.cloudera.org:8080/#/c/17217/3/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/17217/3/src/kudu/tablet/tablet_metadata.cc@841 PS3, Line 841: ommit_timestamp); > nit: since that's emplace semantics, is it possible to drop this piece? Seems like we can't, based on the ASAN errors in https://gerrit.cloudera.org/c/17233/1 that this is based on top of. I left a comment in that patch. -- To view, visit http://gerrit.cloudera.org:8080/17217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935 Gerrit-Change-Number: 17217 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 31 Mar 2021 05:39:31 +0000 Gerrit-HasComments: Yes
