Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17217 )
Change subject: KUDU-2612: route txn op dispatching errors to write ops ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/client/batcher.cc@509 PS5, Line 509: if (resp_.has_error() && > nit: The 'code' isn't used anywhere in the code below except for this 'if ( Done http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/17217/5/src/kudu/tablet/tablet_metadata.cc@839 PS5, Line 839: txn_metadata->set_commit_timestamp(commit_timestamp); > nit: why not just FindOrDie() given there is CHECK(txn_metadata) below? Done -- To view, visit http://gerrit.cloudera.org:8080/17217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf85e0724ee579cb20dac642b82e3228faf90935 Gerrit-Change-Number: 17217 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 03 Apr 2021 02:18:33 +0000 Gerrit-HasComments: Yes
