Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17245 )
Change subject: KUDU-2871 support TLSv1.3 in Kudu RPC (Java part) ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/17245/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java: PS7: The story with making TLSv1.3-related updates to this test. I didn't know this tests existed: first I found /TestNegotiation.java and created TestNegotiationTLSv13.java to add a scenario based on external mini-cluster. Only later on I found this one, and I realized it would require making changes in the way how this scenario updated Netty pipeline after Negotiator senses that the TLS handshake is complete but it still has some data to be sent to the server side. So, given I had already implemented a thorough test scenario to make sure Kudu Java client can talk TLSv1.3 with Kudu servers, I decided not to update this test scenario to work for TLSv1.3 but rather limit it to TLSv1.2 and prior protocol versions. Let me know if there is a need to make this scenario work for TLSv1.3 as well. If so, I'd rather to do that in a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/17245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I884170bdbded8b4017a80db34ecc0a755426c5c2 Gerrit-Change-Number: 17245 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 05 Apr 2021 23:08:55 +0000 Gerrit-HasComments: Yes
