Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17245 )
Change subject: KUDU-2871 support TLSv1.3 in Kudu RPC (Java part) ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/17245/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiationTLSv13.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiationTLSv13.java: http://gerrit.cloudera.org:8080/#/c/17245/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiationTLSv13.java@56 PS7, Line 56: public class TestNegotiationTLSv13 { Maybe add a note here that TestNegotiator has the tests for TLS versions earlier than 1.3 and add a note in that test about this one. http://gerrit.cloudera.org:8080/#/c/17245/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java: PS7: > The story with making TLSv1.3-related updates to this test. I didn't know Perhaps just add a TODO by the ENABLED_PROTOCOLS to enhance the test for v1.3? -- To view, visit http://gerrit.cloudera.org:8080/17245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I884170bdbded8b4017a80db34ecc0a755426c5c2 Gerrit-Change-Number: 17245 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 06 Apr 2021 14:15:39 +0000 Gerrit-HasComments: Yes
