Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17267
to look at the new patch set (#3).
Change subject: [master][tool] KUDU-2181 Tool to orchestrate adding a master
......................................................................
[master][tool] KUDU-2181 Tool to orchestrate adding a master
This tool orchestrates the mechanism to add a master to an existing
Kudu cluster using the changes made previously including the add master
Raft change config.
This tool must be run from the master being added.
Outline of steps:
- Bring up master from supplied flags
- Invoke add master Raft change config RPC
- Determine whether new master has caught up from WAL
and ksck is healthy.
- If yes, we are done else continue below
- Delete system catalog on the new master
- Copy system catalog from one of the existing masters
- Verify ksck is healthy.
- Shutdown the new master
The tool now manages bringing up the new master process, copying
system catalog and hence bunch of functionality from the
dynamic_multi_master test is no longer needed and hence deleted.
Using Subprocess we need to shutdown the new master and hence can't
verify certain state which included contacting new master directly
immediately after adding new master. Function
VerifyClusterAfterMasterAddition() covers comprehensive verification
steps so not missing out by removing those steps.
TODO: Verify the tool on a real cluster.
Change-Id: I8f99cf2b3f1738c4127c7e7288beab61daf42e7b
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_test_util.cc
9 files changed, 521 insertions(+), 346 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/17267/3
--
To view, visit http://gerrit.cloudera.org:8080/17267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f99cf2b3f1738c4127c7e7288beab61daf42e7b
Gerrit-Change-Number: 17267
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
