Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17267 )
Change subject: [master][tool] KUDU-2181 Tool to orchestrate adding a master ...................................................................... Patch Set 4: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/17267/4/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17267/4/src/kudu/master/dynamic_multi_master-test.cc@374 PS4, Line 374: enable_kerberos Thanks for adding this! http://gerrit.cloudera.org:8080/#/c/17267/4/src/kudu/master/dynamic_multi_master-test.cc@375 PS4, Line 375: CHECK_NOTNULL nit: can just use CHECK(). CHECK_NOTNULL() returns the pointer (allowing you to do things like CHECK_NOTNULL(foo)->bar(). http://gerrit.cloudera.org:8080/#/c/17267/4/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/17267/4/src/kudu/tools/tool_action_master.cc@367 PS4, Line 367: NotFound nit: perhaps InvalidArgument would be more natural? -- To view, visit http://gerrit.cloudera.org:8080/17267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f99cf2b3f1738c4127c7e7288beab61daf42e7b Gerrit-Change-Number: 17267 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 20 Apr 2021 05:25:39 +0000 Gerrit-HasComments: Yes
