Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17266 )
Change subject: [mini-cluster] Refactor to expose flags of ExternalMaster ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17266/2/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/17266/2/src/kudu/mini-cluster/external_mini_cluster.cc@1433 PS2, Line 1433: const auto& common_flags = GetCommonFlags(); : flags.insert(flags.end(), common_flags.begin(), common_flags.end()); : flags.push_back(Substitute("--rpc_bind_addresses=$0", bound_rpc_.ToString())); : if (bound_http_.Initialized()) { : flags.push_back(Substitute("--webserver_interface=$0", bound_http_.host())); : flags.push_back(Substitute("--webserver_port=$0", bound_http_.port())); : } else { : flags.push_back(Substitute("--webserver_interface=$0", bound_rpc_.host())); : flags.emplace_back("--webserver_port=0"); : } If we pushed all of this into GetCommonStartFlags(), would we actually need two Get*Flags() methods? http://gerrit.cloudera.org:8080/#/c/17266/2/src/kudu/mini-cluster/external_mini_cluster.cc@1509 PS2, Line 1509: push_back nit: why not emplace_back for these? -- To view, visit http://gerrit.cloudera.org:8080/17266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeff3b0d6bc0021ce2aa50e8022542fb32250e07 Gerrit-Change-Number: 17266 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 09 Apr 2021 18:09:59 +0000 Gerrit-HasComments: Yes
