Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17266 )
Change subject: [mini-cluster] Refactor to expose flags of ExternalMaster ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17266/2/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/17266/2/src/kudu/mini-cluster/external_mini_cluster.cc@1433 PS2, Line 1433: const auto& common_flags = GetCommonFlags(bound_rpc_, bound_http_); : flags.insert(flags.end(), common_flags.begin(), common_flags.end()); : return StartProcess(flags); : } : : Status ExternalMaster::WaitForCatalogManager(WaitMode wait_mode) { : unique_ptr<MasterServiceProxy> proxy(new MasterServiceProxy( : opts_.messenger, bound_rpc_addr(), bound_rpc_addr().host())); : Stopwatch sw; : s > If we pushed all of this into GetCommonStartFlags(), would we actually need Good point. http://gerrit.cloudera.org:8080/#/c/17266/2/src/kudu/mini-cluster/external_mini_cluster.cc@1509 PS2, Line 1509: <string> > nit: why not emplace_back for these? No reason. I had simply moved them from ExternalMaster::Start() function. -- To view, visit http://gerrit.cloudera.org:8080/17266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeff3b0d6bc0021ce2aa50e8022542fb32250e07 Gerrit-Change-Number: 17266 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 09 Apr 2021 21:28:15 +0000 Gerrit-HasComments: Yes
