Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17315 )
Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/integration-tests/txn_status_table-itest.cc@225 PS2, Line 225: LOG(INFO) << out; Is this useful even after the test is already ready and passing? I guess it's possible to remove this already, no? http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/tools/ksck_remote.cc@589 PS2, Line 589: LOG(ERROR) << Substitute("unable to open txn status table $0: $1", : TxnStatusTablet::kTxnStatusTableName, s.ToString()); : return; Just make sure I understand this correctly: does it mean this error message will be printed when running this new tool against an older system or a newer system run without transaction support (i.e. --txn_manager_enabled=false)? http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/tools/tool_action_cluster.cc@76 PS2, Line 76: "VERSION_SUMMARIES, TABLET_SUMMARIES, TABLE_SUMMARIES, SYSTEM_TABLE_SUMMARIES" Add a comma and a space before the closing quote? -- To view, visit http://gerrit.cloudera.org:8080/17315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8162f6eb046d98791c6bdeb5c15a0af72487300d Gerrit-Change-Number: 17315 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 15 Apr 2021 06:05:08 +0000 Gerrit-HasComments: Yes
