Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17315 )
Change subject: [ksck] KUDU-3258: allow ksck and rebalancer to work on txn status table ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/integration-tests/txn_status_table-itest.cc@225 PS2, Line 225: ASSERT_OK(RunKudu > Is this useful even after the test is already ready and passing? I guess i Indeed, this was useful for debugging, will remove. http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/tools/ksck_remote.cc@589 PS2, Line 589: // If there is no table, just exit without logging anything (e.g. if : // we're communicating with an older version of Kudu that doesn't support : // tran > Just make sure I understand this correctly: does it mean this error message Good catch -- updated so if not found, we don't log anything. http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/17315/2/src/kudu/tools/tool_action_cluster.cc@76 PS2, Line 76: "VERSION_SUMMARIES, TABLET_SUMMARIES, TABLE_SUMMARIES, " > Add a comma and a space before the closing quote? Done -- To view, visit http://gerrit.cloudera.org:8080/17315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8162f6eb046d98791c6bdeb5c15a0af72487300d Gerrit-Change-Number: 17315 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 18 Apr 2021 22:45:47 +0000 Gerrit-HasComments: Yes
