Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 )
Change subject: KUDU-3223: Quota management for table write ...................................................................... Patch Set 23: (9 comments) > Patch Set 21: > > (18 comments) http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc File src/kudu/integration-tests/write_quota-itest.cc: http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@128 PS21, Line 128: canner scanner( > nit: "Table" should be singular Ack http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@154 PS21, Line 154: > nit: use kCamelCase? Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@197 PS21, Line 197: Status CreateClientForUser(const string& user, shared_ptr<KuduClient>* client) const { : // Many tests will expect operations to fail, so let's get there quicker by : // setting a low timeout. : > Unused? Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@216 PS21, Line 216: > I tried this, but most of cases failed because the smallest value of FLAGS_ Ack http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@257 PS21, Line 257: > No, here is a little tricky. This case targets to test disk size limit, so Ack http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@270 PS21, Line 270: 1000 > I found this break the test case. I guess the possible reason is the in mem Ack http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@351 PS21, Line 351: // Refuse the table limit change if the user is not superuser > nit: many of these INFO logs seem more useful as a code comments than glog Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@402 PS21, Line 402: client > Done Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@407 PS21, Line 407: NO_FATALS(ModifyLimit(2L * > size limit test case is very difficult to design and test. Every time I cha Done -- To view, visit http://gerrit.cloudera.org:8080/17273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dbf365ad59f17c0a4e2e7ea6a5afaa7680724b0 Gerrit-Change-Number: 17273 Gerrit-PatchSet: 23 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 20 Apr 2021 09:37:31 +0000 Gerrit-HasComments: Yes
