Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 )
Change subject: KUDU-3223: Quota management for table write ...................................................................... Patch Set 26: (12 comments) http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/client/client.h@1314 PS21, Line 1314: /// @note It is experimental and may change > Given the feature is currently experimental, can you also add a note? Espec Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/client/client.h@1328 PS21, Line 1328: /// > I don't think adding arguments (even arguments with defaults) is ABI compat Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc File src/kudu/integration-tests/write_quota-itest.cc: http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@128 PS21, Line 128: canner scanner( > Ack Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@154 PS21, Line 154: > Done Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/integration-tests/write_quota-itest.cc@197 PS21, Line 197: Status CreateClientForUser(const string& user, shared_ptr<KuduClient>* client) const { : // Many tests will expect operations to fail, so let's get there quicker by : // setting a low timeout. : > Done Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/master/catalog_manager.cc@2754 PS21, Line 2754: l.data().owner(), : schema); : > Oh, yes, let me try. Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/master/catalog_manager.cc@3417 PS21, Line 3417: writing, and authz token has a fixed expiration time. We cannot : // disable write immediately. > nit: why not just _not_ set the field, and rely on callers to use has_disk_ Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/master/catalog_manager.cc@3424 PS21, Line 3424: } : if (!disallow_write && > Rather than doing this lookup again, can we pass the 'table' instance from Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/master/catalog_manager.cc@3426 PS21, Line 3426: table_lock.data().pb.h > Done Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/master/catalog_manager.cc@3435 PS21, Line 3435: "row count limit is $3, size limit > By the time this is called, isn't the lock already taken at L3257? Maybe we Done http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/master/catalog_manager.cc@3443 PS21, Line 3443: > hmm, I think both has_table_disk_size_limit() and compare with -1 are neces Ack http://gerrit.cloudera.org:8080/#/c/17273/21/src/kudu/master/catalog_manager.cc@3462 PS21, Line 3462: > Done Done -- To view, visit http://gerrit.cloudera.org:8080/17273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dbf365ad59f17c0a4e2e7ea6a5afaa7680724b0 Gerrit-Change-Number: 17273 Gerrit-PatchSet: 26 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 21 Apr 2021 02:23:39 +0000 Gerrit-HasComments: Yes
