Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17392
to look at the new patch set (#2).
Change subject: KUDU-2612: update C++ client API to commit a transaction
......................................................................
KUDU-2612: update C++ client API to commit a transaction
This patch updates the signature of the KuduTransaction::Commit()
method to address initial feedback received after presenting the
txn-related API to the Kudu team. The idea is to make the API easier
to use, since txn.Commit(false) looks a bit vague and might be confusing
as well.
In essence, the 'wait' parameter is gone and now there are two methods:
* KuduTransaction::Commit()
* KuduTransaction::StartCommit()
The former starts committing a multi-row transaction and waits for the
commit phase to finalize. The latter just starts the commit phase for
a multi-row transaction and returns, not awaiting for the commit phase
to finalize.
Change-Id: Iecac338a753e559597a9348e68c9b09813cc8105
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/transaction-internal.cc
M src/kudu/client/transaction-internal.h
M src/kudu/integration-tests/txn_commit-itest.cc
M src/kudu/integration-tests/txn_status_manager-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
8 files changed, 72 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/17392/2
--
To view, visit http://gerrit.cloudera.org:8080/17392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecac338a753e559597a9348e68c9b09813cc8105
Gerrit-Change-Number: 17392
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
