Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17392 )
Change subject: KUDU-2612: update C++ client API to commit a transaction ...................................................................... KUDU-2612: update C++ client API to commit a transaction This patch updates the signature of the KuduTransaction::Commit() method to address recent feedback on the txn-related API. The idea is to make the API easier to use, since txn.Commit(false) looks a bit vague and might be confusing as well. In essence, the 'wait' parameter is gone and now there are two methods: * KuduTransaction::Commit() * KuduTransaction::StartCommit() The former starts committing a multi-row transaction and waits for the commit phase to finalize. The latter just starts the commit phase for a multi-row transaction and returns, not awaiting for the commit phase to finalize. Change-Id: Iecac338a753e559597a9348e68c9b09813cc8105 Reviewed-on: http://gerrit.cloudera.org:8080/17392 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/transaction-internal.cc M src/kudu/client/transaction-internal.h M src/kudu/integration-tests/txn_commit-itest.cc M src/kudu/integration-tests/txn_status_manager-itest.cc M src/kudu/integration-tests/txn_write_ops-itest.cc 8 files changed, 71 insertions(+), 48 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iecac338a753e559597a9348e68c9b09813cc8105 Gerrit-Change-Number: 17392 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
