Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17393

to look at the new patch set (#2).

Change subject: KUDU-2612: update Java client API to commit a transaction
......................................................................

KUDU-2612: update Java client API to commit a transaction

This patch updates the signature of the KuduTransaction::commit()
method to address recent feedback on the txn-related API.  The idea is
to make the API easier to use, since txn.commit(false) looks a bit vague
and might be confusing as well.

In essence, the 'wait' parameter is gone and now there are two methods:
  * KuduTransaction.commit()
  * KuduTransaction.startCommit()

The former starts committing a multi-row transaction and waits for the
commit phase to finalize.  The latter just starts the commit phase for
a multi-row transaction and returns, not awaiting for the commit phase
to finalize.

These changes mirror recent changes in the C++ client API.

Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
2 files changed, 87 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/17393/2
--
To view, visit http://gerrit.cloudera.org:8080/17393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
Gerrit-Change-Number: 17393
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)

Reply via email to