Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17393 )
Change subject: KUDU-2612: update Java client API to commit a transaction ...................................................................... KUDU-2612: update Java client API to commit a transaction This patch updates the signature of the KuduTransaction::commit() method to address recent feedback on the txn-related API. The idea is to make the API easier to use, since txn.commit(false) looks a bit vague and might be confusing as well. In essence, the 'wait' parameter is gone and now there are two methods: * KuduTransaction.commit() * KuduTransaction.startCommit() The former starts committing a multi-row transaction and waits for the commit phase to finalize. The latter just starts the commit phase for a multi-row transaction and returns, not awaiting for the commit phase to finalize. These changes mirror recent changes in the C++ client API. Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7 Reviewed-on: http://gerrit.cloudera.org:8080/17393 Tested-by: Kudu Jenkins Reviewed-by: Grant Henke <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java 2 files changed, 87 insertions(+), 58 deletions(-) Approvals: Kudu Jenkins: Verified Grant Henke: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7 Gerrit-Change-Number: 17393 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
