Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong,
Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17399
to look at the new patch set (#4).
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
KUDU-3164: Add table comment support to Kudu
This patch adds the basic plumbing for table comments,
synchronizing comments with HMS both using the
notification log listener and via tooling, and setting the
comment on CREATE TABLE and ALTER TABLE requests in
the C++ client.
The maximum comment length is 256 characters by default
which aligns with HMS/Apache Impala maximum comment
lengths, but it's configurable with the
max_table_comment_length flag.
Supporting this in the Java and Python clients, and backup
and restore jobs will come in follow on patches.
Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client.proto
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.h
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_table.cc
M www/table.mustache
31 files changed, 442 insertions(+), 119 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/17399/4
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
