Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17399 )
Change subject: KUDU-3164: Add table comment support to Kudu ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc@928 PS3, Line 928: req.set_comment(data_->comment_.get()); > I think silently dropping is probably okay given that is how we have handle Yep, that sounds reasonable: at least for table owner we would have similar behavior, and that didn't seem to be a big deal. I guess we should just document that in release notes. http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc@191 PS3, Line 191: DEFINE_int32 > I suppose not. There are a ton of those cases in this file. Perhaps it coul SGTM -- To view, visit http://gerrit.cloudera.org:8080/17399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2 Gerrit-Change-Number: 17399 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 08 May 2021 03:48:43 +0000 Gerrit-HasComments: Yes
