Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17431 )
Change subject: KUDU-2612 automatically flush sessions on txn commit ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17431/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17431/2//COMMIT_MSG@22 PS2, Line 22: So, I opted : not to perform the consistency check as a part of KuduSession::Apply(), : rather relying on the logic of KuduSession::Flush() and : KuduSession::FlushAsync() methods instead. This means that the check performed in StartCommit() is best-effort, i.e. in case of concurrent activity on the session while the transaction being committed, it might happen that some operations are applied to the session, but they might not get to the server when the transaction is committed. Is it good enough or we want to be strict on this and protect against concurrent activity on session handles while a transaction is being committed? -- To view, visit http://gerrit.cloudera.org:8080/17431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2480129a99fb19d16868e14f9b9e33c83e3d8e7f Gerrit-Change-Number: 17431 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 13 May 2021 21:49:56 +0000 Gerrit-HasComments: Yes
