Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17431 )
Change subject: KUDU-2612 automatically flush sessions on txn commit ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17431/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17431/2/src/kudu/client/client-test.cc@7433 PS2, Line 7433: ASSERT_OK(session->SetFlushMode(KuduSession::MANUAL_FLUSH)); > That looks like a viable option, but why would anybody add rows into a buff Good point -- I think I've come around to keeping it as is. My initial impression was that MANUAL_FLUSH mode is meant to give users more control of _whether_ to flush at all, and when. I think it's more likely though that users mainly use MANUAL_FLUSH mode to control the size of batches, while still meaning to flush. In that sense, automatically flushing is indeed much less error prone. -- To view, visit http://gerrit.cloudera.org:8080/17431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2480129a99fb19d16868e14f9b9e33c83e3d8e7f Gerrit-Change-Number: 17431 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 May 2021 03:28:30 +0000 Gerrit-HasComments: Yes
