Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )
Change subject: KUDU-1884: Set sasl_protocol_name for the TxnSystemClient ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG@9 PS2, Line 9: witha with a http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG@10 PS2, Line 10: embeded embedded http://gerrit.cloudera.org:8080/#/c/17480/2//COMMIT_MSG@13 PS2, Line 13: This logic matches that in server_base.cc for server : messenger configuration. Does it make sense to add a test, at least catch regressions once the overlooked place for the kerberos principal customization is found? It seems a small end-to-end scenario might be added into client-test.cc or txn_write_ops-itest.cc -- To view, visit http://gerrit.cloudera.org:8080/17480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf Gerrit-Change-Number: 17480 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 21 May 2021 04:42:00 +0000 Gerrit-HasComments: Yes
