Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17480 )
Change subject: KUDU-1884: set sasl_protocol_name for the TxnSystemClient ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17480/5/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/17480/5/src/kudu/transactions/txn_system_client.cc@72 PS5, Line 72: DECLARE_string(keytab_file); > are these used? Nice catch: indeed, there are not used -- not sure why there are here, probably left-overs from previous iterations on this patch. Removed. -- To view, visit http://gerrit.cloudera.org:8080/17480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b7c7fd154796215bd3a3ce748a2fd3155adebf Gerrit-Change-Number: 17480 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 25 May 2021 17:24:49 +0000 Gerrit-HasComments: Yes
