Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17499 )
Change subject: KUDU-2612: disable TxnSystemClient initialization by default ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17499/1/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/17499/1/src/kudu/transactions/txn_system_client.cc@58 PS1, Line 58: disable_txn_system_client_init If we are going this route and this flag starts to appear not only in tests, maybe it's a good point to rename it to be similar to the majority of the flags with 'enable/disable' semantics? What do you think about renaming this into 'txn_system_client_enable' or alike? I guess the main thing is to have 'enable_something' instead of 'disable_something' -- that's a bit easier to read and understand. -- To view, visit http://gerrit.cloudera.org:8080/17499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c020a66db484f88ae1cb7c15d860d503a3f8a3b Gerrit-Change-Number: 17499 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 25 May 2021 01:29:21 +0000 Gerrit-HasComments: Yes
