Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17499 )
Change subject: KUDU-2612: disable TxnSystemClient initialization by default ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Overall looks good, just one quick question. http://gerrit.cloudera.org:8080/#/c/17499/2/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/17499/2/src/kudu/transactions/txn_system_client.cc@432 PS2, Line 432: // completes. Does it make sense to log about this no-op which returns Status::OK()? -- To view, visit http://gerrit.cloudera.org:8080/17499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c020a66db484f88ae1cb7c15d860d503a3f8a3b Gerrit-Change-Number: 17499 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 25 May 2021 06:16:44 +0000 Gerrit-HasComments: Yes
