Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17518 )
Change subject: [java] KUDU-3267 Improve logging on writes to non-existent partitions ...................................................................... Patch Set 2: Code-Review+2 (3 comments) LGTM, just one nit if you think it's worth addressing it. http://gerrit.cloudera.org:8080/#/c/17518/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17518/1//COMMIT_MSG@19 PS1, Line 19: Not found: ([0x000000018005BDAA4BF52400, 0x000000028005BCC2F4C85400)) > Done Thank you! http://gerrit.cloudera.org:8080/#/c/17518/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/17518/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@373 PS1, Line 373: String.format("%s: %s", failure.getMessage(), operati > So the failure.getMessage() actually has a space at the end of the string. Ah, I see. I didn't realize the message had trailing space. Anyways, I guess the format I suggested looks good as well :) http://gerrit.cloudera.org:8080/#/c/17518/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/17518/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@818 PS2, Line 818: rowError nit: could replace this with 'new RowError(status, operation)' since the 'rowError' isn't used anywhere else in this code block -- To view, visit http://gerrit.cloudera.org:8080/17518 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia24582de6b060e908f5ecbc46e2638b95cd567b3 Gerrit-Change-Number: 17518 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 27 May 2021 23:11:30 +0000 Gerrit-HasComments: Yes
