Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/17518 )
Change subject: [java] KUDU-3267 Improve logging on writes to non-existent
partitions
......................................................................
Patch Set 3:
Overall looks good, just make sure the :kudu-client:checkstyleTest target can
be built successfully. Right now it fails:
07:34:42 > Task :kudu-client:checkstyleTest FAILED
07:34:42 [ant:checkstyle] [WARN]
/home/jenkins-slave/workspace/kudu-master/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java:20:50:
Using the '.*' form of import should be avoided -
org.apache.kudu.test.ClientTestUtil.*. [AvoidStarImport]
07:34:42 [ant:checkstyle] [WARN]
/home/jenkins-slave/workspace/kudu-master/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java:556:
Line is longer than 100 characters (found 119). [LineLength]
07:34:42 [ant:checkstyle] [WARN]
/home/jenkins-slave/workspace/kudu-master/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java:559:18:
'(' is preceded with whitespace. [MethodParamPad]
07:34:42 [ant:checkstyle] [WARN]
/home/jenkins-slave/workspace/kudu-master/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java:564:
Line is longer than 100 characters (found 126). [LineLength]
07:34:42 [ant:checkstyle] [WARN]
/home/jenkins-slave/workspace/kudu-master/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java:567:18:
'(' is preceded with whitespace. [MethodParamPad]
07:34:42 [ant:checkstyle] [WARN]
/home/jenkins-slave/workspace/kudu-master/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java:572:
Line is longer than 100 characters (found 128). [LineLength]
--
To view, visit http://gerrit.cloudera.org:8080/17518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia24582de6b060e908f5ecbc46e2638b95cd567b3
Gerrit-Change-Number: 17518
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Jun 2021 17:07:51 +0000
Gerrit-HasComments: No
