Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17574 )
Change subject: [docker] Add option to force the latest tag ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17574/1/docker/docker-build.py File docker/docker-build.py: http://gerrit.cloudera.org:8080/#/c/17574/1/docker/docker-build.py@118 PS1, Line 118: nit: off-by-one indent http://gerrit.cloudera.org:8080/#/c/17574/1/docker/docker-build.py@121 PS1, Line 121: If passed, skips adding a tag using `-latest` along with the ' : 'versioned tag nit: is it worth mentioning that this overrides the --force-latest tag above? Otherwise, maybe update the code starting with 'if not opts.skip_latest' clause at line 287? -- To view, visit http://gerrit.cloudera.org:8080/17574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13ff38683d3f923577f8728fdf30a4b3e09bc943 Gerrit-Change-Number: 17574 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Jun 2021 18:03:19 +0000 Gerrit-HasComments: Yes
