Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17574 )

Change subject: [docker] Add option to force the latest tag
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17574/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17574/1//COMMIT_MSG@17
PS1, Line 17: editing
> typo
Done


http://gerrit.cloudera.org:8080/#/c/17574/1/docker/docker-build.py
File docker/docker-build.py:

http://gerrit.cloudera.org:8080/#/c/17574/1/docker/docker-build.py@118
PS1, Line 118:
> nit: off-by-one indent
Done


http://gerrit.cloudera.org:8080/#/c/17574/1/docker/docker-build.py@118
PS1, Line 118: as
> Nit: space after "base"
Done


http://gerrit.cloudera.org:8080/#/c/17574/1/docker/docker-build.py@121
PS1, Line 121: If passed, skips adding a tag using `-latest` along with the '
             :                       'versioned tag
> nit: is it worth mentioning that this overrides the --force-latest tag abov
Done



--
To view, visit http://gerrit.cloudera.org:8080/17574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13ff38683d3f923577f8728fdf30a4b3e09bc943
Gerrit-Change-Number: 17574
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Jun 2021 15:56:14 +0000
Gerrit-HasComments: Yes

Reply via email to