Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 )
Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17585/2/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: http://gerrit.cloudera.org:8080/#/c/17585/2/src/kudu/consensus/consensus_peers.cc@508 PS2, Line 508: peer_proxy_factory_ >From the test code looks like this could be null. Do we need to check for >not-null ptr or return an error? http://gerrit.cloudera.org:8080/#/c/17585/2/src/kudu/consensus/peer_manager.cc File src/kudu/consensus/peer_manager.cc: http://gerrit.cloudera.org:8080/#/c/17585/2/src/kudu/consensus/peer_manager.cc@77 PS2, Line 77: unique_ptr<PeerProxy> peer_proxy; : WARN_NOT_OK(peer_proxy_factory_->NewProxy(peer_pb, &peer_proxy), : Substitute("Unable to create proxy for $0", peer_pb.permanent_uuid())); Since the proxy factory is being supplied to NewRemotePeer, this could move to NewRemotePeer() itself utilizing the CreateIfNeeded() function and no need to supply peer_proxy to NewRemotePeer(). -- To view, visit http://gerrit.cloudera.org:8080/17585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22d870ecc526fa47b97f6856c3b023bc1ec029c7 Gerrit-Change-Number: 17585 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Jun 2021 17:40:03 +0000 Gerrit-HasComments: Yes
