Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 )
Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/17585/4/src/kudu/consensus/consensus-test-util.h File src/kudu/consensus/consensus-test-util.h: http://gerrit.cloudera.org:8080/#/c/17585/4/src/kudu/consensus/consensus-test-util.h@341 PS4, Line 341: class NoOpTestPeerProxy : public TestPeerProxy { > warning: parameter 'peer_pb' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/17585/4/src/kudu/consensus/consensus-test-util.h@342 PS4, Line 342: public: > This could be dangerous. The ownership of the raw ptr has been transferred Existing test usage of Peers has been unsafe in similar ways (e.g. creating a proxy as a raw pointer and passing ownership to the Peers). Updated this impl a bit to at least pass ASAN, and added a comment that this can be unsafe and that users should be wary. If you feel strongly that this isn't sufficient for tests, I can go about making more drastic changes. http://gerrit.cloudera.org:8080/#/c/17585/4/src/kudu/consensus/consensus_peers-test.cc File src/kudu/consensus/consensus_peers-test.cc: http://gerrit.cloudera.org:8080/#/c/17585/4/src/kudu/consensus/consensus_peers-test.cc@152 PS4, Line 152: &factory, > This piece looks problematic even before this change. Done -- To view, visit http://gerrit.cloudera.org:8080/17585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22d870ecc526fa47b97f6856c3b023bc1ec029c7 Gerrit-Change-Number: 17585 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 11 Jun 2021 19:47:05 +0000 Gerrit-HasComments: Yes
