Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17585 )
Change subject: [consensus] KUDU-2302: don't crash if new leader can't resolve peer ...................................................................... Patch Set 8: Code-Review+1 (3 comments) Overall looks good to me, but it seems the rate of flakiness for the newly added test is a bit high. http://gerrit.cloudera.org:8080/#/c/17585/4/src/kudu/integration-tests/raft_consensus_election-itest.cc File src/kudu/integration-tests/raft_consensus_election-itest.cc: http://gerrit.cloudera.org:8080/#/c/17585/4/src/kudu/integration-tests/raft_consensus_election-itest.cc@167 PS4, Line 167: TEST_F(RaftConsensusElectionITest, TestNewLeaderCantResolvePeers) { > Tried it and the test passes. Cool, thanks a lot for verifying that! http://gerrit.cloudera.org:8080/#/c/17585/4/src/kudu/integration-tests/raft_consensus_election-itest.cc@247 PS4, Line 247: }); : }; : NO_FATALS(wait_for_some_elections()); : NO_FATALS(cluster_->AssertNoCrashes()); : : // Stop injecting latency so we can get a stable leader. > Done Thank you! http://gerrit.cloudera.org:8080/#/c/17585/8/src/kudu/integration-tests/raft_consensus_election-itest.cc File src/kudu/integration-tests/raft_consensus_election-itest.cc: http://gerrit.cloudera.org:8080/#/c/17585/8/src/kudu/integration-tests/raft_consensus_election-itest.cc@217 PS8, Line 217: ASSERT_LT(initial_cstate.current_term() + 10, cstate.current_term()); It seems this fails rather often, even in RELEASE build: src/kudu/integration-tests/raft_consensus_election-itest.cc:218 Expected: (initial_cstate.current_term() + 10) < (cstate.current_term()), actual: 30 vs 22 Maybe, it's worth switch this scenario into manual election mode? -- To view, visit http://gerrit.cloudera.org:8080/17585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22d870ecc526fa47b97f6856c3b023bc1ec029c7 Gerrit-Change-Number: 17585 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 12 Jun 2021 01:55:06 +0000 Gerrit-HasComments: Yes
