Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17636 )
Change subject: [master] allow setting BlockCacheMetrics twice ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17636/1/src/kudu/master/master_options.cc File src/kudu/master/master_options.cc: http://gerrit.cloudera.org:8080/#/c/17636/1/src/kudu/master/master_options.cc@59 PS1, Line 59: block_cache_metrics_reset_behavior_ = Cache::kKeepFirstMetrics; Nit: This could be part of the constructor initliazer list -- To view, visit http://gerrit.cloudera.org:8080/17636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bb9c6f382a26654f2d324676506441f370ffe61 Gerrit-Change-Number: 17636 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Jun 2021 20:29:38 +0000 Gerrit-HasComments: Yes
