Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17636 )
Change subject: [master] allow setting BlockCacheMetrics twice ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17636/2/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/17636/2/src/kudu/util/cache.h@85 PS2, Line 85: metrics_behavior > I kept it as kKeep since that's the current behavior in all cases. As for d Well, in nvm_cache.cc the current behavior is more kReset than kKeep. Talking about kKeep in cache.cc is only for the case of running SetMetrics() in the context of a test, otherwise a process would crash with SIGABRT. With that, I guess we are free to converge with whatever behavior makes more sense. I agree: it seems kKeep would be a good option for tests. Yeah, introducing parameters by default is a tricky business, so I'm OK with not introducing a default by any other means. http://gerrit.cloudera.org:8080/#/c/17636/2/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/17636/2/src/kudu/util/nvm_cache.cc@662 PS2, Line 662: return; What do you think of adding the CHECK(IsGTest()) here as it's in cache.cc? -- To view, visit http://gerrit.cloudera.org:8080/17636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bb9c6f382a26654f2d324676506441f370ffe61 Gerrit-Change-Number: 17636 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Jul 2021 00:04:23 +0000 Gerrit-HasComments: Yes
