Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17636 )
Change subject: [master] allow setting BlockCacheMetrics twice ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/17636/2/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/17636/2/src/kudu/util/cache.h@85 PS2, Line 85: metrics_policy) > Well, in nvm_cache.cc the current behavior is more kReset than kKeep. Talki Ack http://gerrit.cloudera.org:8080/#/c/17636/2/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/17636/2/src/kudu/util/nvm_cache.cc@662 PS2, Line 662: (metri > What do you think of adding the CHECK(IsGTest()) here as it's in cache.cc? Done -- To view, visit http://gerrit.cloudera.org:8080/17636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bb9c6f382a26654f2d324676506441f370ffe61 Gerrit-Change-Number: 17636 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Jul 2021 00:28:44 +0000 Gerrit-HasComments: Yes
