Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17724 )
Change subject: [partition] RangeHashSchema --> PerRangeHashBucketSchemas ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17724/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17724/1/src/kudu/common/partition.h@160 PS1, Line 160: struct RangeWithHashSchemas { : std::string lower; : std::string upper; : HashBucketSchemas hash_schemas; : }; > Do you think it's worth making a typedef of vector<RangeWithHashSchemas> as Good point. Done. -- To view, visit http://gerrit.cloudera.org:8080/17724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic64a956a87c3d66cb2a14f4a3da7f57948518f17 Gerrit-Change-Number: 17724 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 23 Jul 2021 23:19:56 +0000 Gerrit-HasComments: Yes
