Hello Mahesh Reddy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17724
to look at the new patch set (#3).
Change subject: [partition] RangeHashSchema --> PerRangeHashBucketSchemas
......................................................................
[partition] RangeHashSchema --> PerRangeHashBucketSchemas
This patch simply renames the PartitionSchema::RangeHashSchema type
into PartitionSchema::PerRangeHashBucketSchemas, updating the existing
typedef for std::vector<HashBucketSchemas>. I found it's easier to read
and comprehend the code with this change because the PB-based
PartitionSchemaPB::PerRangeHashBucketSchemasPB structure is very close
to what PartitionSchema::PerRangeHashBucketSchemas is.
In addition, this patch introduces a RangesWithHashSchemas typedef for
vector<RangeWithHashSchemas> and updates the signature of the
PartitionSchema::SplitRangeBounds() method.
I also updated the code in master-test and table_locations-itest to
introduce similar typedefs. I found some more room for refactoring
in those two test suites (e.g., there are similar data structures
in both), but I decided not to address that right away to avoid
bloating of this patch.
This patch does not contain any functional changes.
Change-Id: Ic64a956a87c3d66cb2a14f4a3da7f57948518f17
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
6 files changed, 73 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/17724/3
--
To view, visit http://gerrit.cloudera.org:8080/17724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic64a956a87c3d66cb2a14f4a3da7f57948518f17
Gerrit-Change-Number: 17724
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
