Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 )
Change subject: [WIP] KUDU-1959 - Implement server startup progress page for tablet and master servers ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17730/1/src/kudu/server/CMakeLists.txt File src/kudu/server/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17730/1/src/kudu/server/CMakeLists.txt@56 PS1, Line 56: startup_path_handler.cc) nit: it should be in alphabetical order http://gerrit.cloudera.org:8080/#/c/17730/1/src/kudu/server/startup_path_handler.cc File src/kudu/server/startup_path_handler.cc: http://gerrit.cloudera.org:8080/#/c/17730/1/src/kudu/server/startup_path_handler.cc@42 PS1, Line 42: struct Tags { nit: namespaces don't increment indent level, so struct Tags should start at column 0 -- To view, visit http://gerrit.cloudera.org:8080/17730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db1fcf16261d4ced1b3657a697766a5335271b4 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 28 Jul 2021 11:30:39 +0000 Gerrit-HasComments: Yes
