Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17730 )
Change subject: [WIP] KUDU-1959 - Implement server startup progress page for tablet and master servers ...................................................................... Patch Set 4: (6 comments) The new patch will show the contents of the /startup page in the /home page while the server initializing. Once initialized, it will switch back to the regular home page. http://gerrit.cloudera.org:8080/#/c/17730/3/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17730/3/src/kudu/server/server_base.cc@552 PS3, Line 552: // : // NOTE: unlike the other path handlers, > nit: minor rewording, and it's worth adding a note about why this is done s Done http://gerrit.cloudera.org:8080/#/c/17730/3/src/kudu/server/server_base.cc@850 PS3, Line 850: ? FLAGS_gc_tcmalloc_memory_interval_seconds : 60); > nit: move this comment to inside the function, since it describes a portion Done http://gerrit.cloudera.org:8080/#/c/17730/1/src/kudu/server/startup_path_handler.h File src/kudu/server/startup_path_handler.h: http://gerrit.cloudera.org:8080/#/c/17730/1/src/kudu/server/startup_path_handler.h@30 PS1, Line 30: > We try to make sure we keep merged code as clean as possible, even if we're Done http://gerrit.cloudera.org:8080/#/c/17730/3/src/kudu/server/startup_path_handler.cc File src/kudu/server/startup_path_handler.cc: http://gerrit.cloudera.org:8080/#/c/17730/3/src/kudu/server/startup_path_handler.cc@69 PS3, Line 69: RegisterStartupPathHan > nit: to be consistent with existing terminology, prefer calling this Regist Done http://gerrit.cloudera.org:8080/#/c/17730/3/src/kudu/server/startup_path_handler.cc@72 PS3, Line 72: ", "Sta > nit: should be lowercased? Done http://gerrit.cloudera.org:8080/#/c/17730/3/src/kudu/server/startup_path_handler.cc@74 PS3, Line 74: } // namespace kudu > warning: namespace 'kudu' ends with an unrecognized comment [google-readabi Done -- To view, visit http://gerrit.cloudera.org:8080/17730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1db1fcf16261d4ced1b3657a697766a5335271b4 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 19 Aug 2021 17:33:25 +0000 Gerrit-HasComments: Yes
