Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17731 )
Change subject: KUDU-1921 Add ability to require auth/encryption to C++ client ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17731/2/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17731/2/src/kudu/client/client.h@336 PS2, Line 336: If the server doesn't support : /// encryption, or it's disabled, the client will fail to connect. > It should work, but now that I think about it, I wonder if it's a good idea I guess there are two separate items here: * Clarity on the behavior of the client when it connects to a server via local interface and the server configured not to encrypt local connections, so that's documented in the API * Realize what's the appropriate behavior for the client: whether it's OK if the connection isn't encrypted due to the server-side policy even if we call KuduClientBuilder::require_encryption(true). -- To view, visit http://gerrit.cloudera.org:8080/17731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e800eb7c4e2f8787f0adf1f040d47358d29320 Gerrit-Change-Number: 17731 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 29 Jul 2021 18:24:15 +0000 Gerrit-HasComments: Yes
