Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17731 )
Change subject: KUDU-1921 Add ability to require auth/encryption to C++ client ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/17731/6/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17731/6/src/kudu/client/client.h@345 PS6, Line 345: /// Require encryption for the connection to a remote server. : /// : /// If it's set to REQUIRED or REQUIRED_LOOPBACK, the client will : /// require encrypting the traffic between the server and the client. : /// If the server doesn't support encryption, or if it's disabled, the : /// client will fail to connect. : /// : /// Loopback connections are encrypted only if 'encryption_policy' is : /// set to REQUIRE_LOOPBACK, or if it's required by the server. : /// > What do you think of having just one method instead of these two, something Changed it. Actually, I considered doing it this way initially, I don't know why I didn't. http://gerrit.cloudera.org:8080/#/c/17731/6/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/17731/6/src/kudu/integration-tests/security-itest.cc@665 PS6, Line 665: shared_ptr<KuduClient> client; > Does it make sense to add SmokeTestCluster() to other successful scenarios Yep, added it. http://gerrit.cloudera.org:8080/#/c/17731/6/src/kudu/integration-tests/security-itest.cc@701 PS6, Line 701: cluster_opts_.enable_kerberos = false; > Do you mind adding a couple of test scenarios where a client which requires Thanks for the suggestion. Changed it to parameterized tests and added all combinations. -- To view, visit http://gerrit.cloudera.org:8080/17731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e800eb7c4e2f8787f0adf1f040d47358d29320 Gerrit-Change-Number: 17731 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 06 Aug 2021 19:07:45 +0000 Gerrit-HasComments: Yes
