Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17743 )

Change subject: KUDU-1954 [maintenance] Add an optional flush-only thread pool
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17743/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17743/3//COMMIT_MSG@7
PS3, Line 7: KUDU-1954
> Reading through the RocksDB link https://github.com/facebook/rocksdb/blob/4
For the RocksDB's example, although now a single 'max_background_jobs' is 
recommend, but a flush only thread pool is still present, created and managed 
internally. The idea of RocksDB is separet flush and compaction threads.

Reduce --memory_pressure_percentage is another way to resolve it, but 
memtracker is used in many places, it will impact other places except MRS or 
DMS?


http://gerrit.cloudera.org:8080/#/c/17743/3//COMMIT_MSG@9
PS3, Line 9: In some special environments,
> I'm curious whether these environments can be categorized as clusters with
Yes, this kind of environment has only 1 disk, maybe HDD, and 
--maintenance_manager_num_threads is configured as 1.
This patch has few effect on compaction, but will help to avoid OOM to a 
certain extent.



--
To view, visit http://gerrit.cloudera.org:8080/17743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dca9d87e7287cc04482a1c18b1e0eefc5f9bcb1
Gerrit-Change-Number: 17743
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Thu, 12 Aug 2021 16:04:58 +0000
Gerrit-HasComments: Yes

Reply via email to