Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17743 )
Change subject: KUDU-1954 [maintenance] Add an optional flush-only thread pool ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/17743/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17743/6//COMMIT_MSG@11 PS6, Line 11: may starve flush OPs, and then cause OOM issue. e.g. the tserver I would still like to see some testing that shows that this actually shows improvement to your workload. Perhaps run some historically crashy, OOM-inducing workloads that seeing how we fare? As mentioned, I suspect there are other configs we can tune, or memory we could track to prevent such workloads from having such drastic consequences. E.g. perhaps we should be more aggressive about tracking memory used in maintenance threads, which would give a more accurate view of whether we should be in rejecting new writes. -- To view, visit http://gerrit.cloudera.org:8080/17743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dca9d87e7287cc04482a1c18b1e0eefc5f9bcb1 Gerrit-Change-Number: 17743 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 24 Aug 2021 22:30:20 +0000 Gerrit-HasComments: Yes
