Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17769 )
Change subject: KUDU-2671 key encoding for custom hash bucket schemas ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/17769/6/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17769/6/src/kudu/client/client.cc@1016 PS6, Line 1016: if (range->hash_bucket_schemas_.empty()) { : schemas_pb->mutable_hash_schemas()->CopyFrom( : data_->partition_schema_.hash_bucket_schemas()) > Ah I see, but within the PartitionSchema class and PartitionSchemaPB we wil Right -- in the implementation we can optimize for the use-case of custom hash schema per range or whatever we want. But we have to keep the Kudu client API backward compatible, so the apps written before adding per-range hash schema can be built/linked with the newer Kudu library. Also, the older clients should be able to work with the new servers, so we have to keep the notion of the table-wide schema at PartitionSchemaPB as is, and interpret it as needed. -- To view, visit http://gerrit.cloudera.org:8080/17769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81aa1c10998d88a1bd5314fc3132037b1c8bbe4b Gerrit-Change-Number: 17769 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 18 Aug 2021 22:25:39 +0000 Gerrit-HasComments: Yes
