Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17769 )
Change subject: KUDU-2671 key encoding for custom hash bucket schemas ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/17769/6/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17769/6/src/kudu/common/partition.cc@1559 PS6, Line 1559: if (!upper.empty() && upper <= range_key) { : has_custom_range = false; : } > Ack Alternatively, it's possible to think about the table-wide hash schema as always present, but it can contains zero hash dimensions (e.g. if no hash partitioning is there at all). However, we should phase out the PartitionSchema::hash_schema() method (here I'm using the notations after the recent renamings). -- To view, visit http://gerrit.cloudera.org:8080/17769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81aa1c10998d88a1bd5314fc3132037b1c8bbe4b Gerrit-Change-Number: 17769 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 18 Aug 2021 22:38:12 +0000 Gerrit-HasComments: Yes
