Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/17674/16/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/17674/16/src/kudu/integration-tests/alter_table-test.cc@2377 PS16, Line 2377: > It is 'Not', I pass VerifyRowCount::kDisable to VerifyTabletReplicaCount, m Ah, my mistake. Somehow missed the "disabled" part. http://gerrit.cloudera.org:8080/#/c/17674/21/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/17674/21/src/kudu/integration-tests/alter_table-test.cc@196 PS21, Line 196: Seems like there are ASAN errors in destructing this. We'll need to add the following line after L195 to ensure the entries are deleted. ValueDeleter deleter(&tablet_servers); -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 21 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 20 Aug 2021 23:37:18 +0000 Gerrit-HasComments: Yes
