Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/17674/16/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/17674/16/src/kudu/integration-tests/alter_table-test.cc@2265 PS16, Line 2265: ); > nit: missing a space Done http://gerrit.cloudera.org:8080/#/c/17674/16/src/kudu/integration-tests/alter_table-test.cc@2299 PS16, Line 2299: > nit: Scanning Done http://gerrit.cloudera.org:8080/#/c/17674/16/src/kudu/integration-tests/alter_table-test.cc@2355 PS16, Line 2355: > I'm curious, if you set this to something very high, would we be able to se If not verify the row count, this test case is stable (I run the test case 100 times, all success), even though I increase the injection latency, write payload, decrease write timeout. I think it more or less like a normal cluster recover procedure when lost majority replicas. On the other hand, when the cluster is recovering, Kudu admins should try to reduce the write pressure of the cluster/table. http://gerrit.cloudera.org:8080/#/c/17674/16/src/kudu/integration-tests/alter_table-test.cc@2377 PS16, Line 2377: ERT_ > nit: Now? It is 'Not', I pass VerifyRowCount::kDisable to VerifyTabletReplicaCount, means only verify tablet schema, not to verify row count. Because we are keep writing the table, and an inject latency is added, tablet copies can't catch up leader in time. -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 18 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 19 Aug 2021 16:28:00 +0000 Gerrit-HasComments: Yes
